Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overwriting objects when copying #530

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Aug 7, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

When copying onto a destination that already exists was not possible, this PR allows for future protocol compatibilities to accept upserts on copy

@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10300101566

Details

  • 61 of 63 (96.83%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 79.449%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/protocols/tus/postgres-locker.ts 14 16 87.5%
Totals Coverage Status
Change from base Build 10251146211: 0.05%
Covered Lines: 13244
Relevant Lines: 16512

💛 - Coveralls

@fenos fenos force-pushed the feat/allow-overwrites-when-copy branch from 1b95180 to a6a6d33 Compare August 8, 2024 10:06
@fenos fenos merged commit d68eb9e into master Aug 8, 2024
1 check passed
@fenos fenos deleted the feat/allow-overwrites-when-copy branch August 8, 2024 11:13
Copy link

github-actions bot commented Aug 8, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants